[ENH] Widget status bar by ales-erjavec · Pull Request #2464 · biolab/orange3

ales-erjavec · 2017-07-11T11:21:38Z

Issue

The OWWidget's 'message_bar' is placed in an inappropriate position above the rest of the GUI causing frequent re-layouts which both flicker the GUI and change the position of controls under the mouse from the unsuspecting user.

Description of changes

Replace the top message area with a summary in a (permanent) status bar at the bottom.
Also add a progress bar widget, mirroring the progressBarValue state.

Includes

Code changes
Tests
Documentation

codecov-io · 2017-07-11T12:12:20Z

Codecov Report

Merging #2464 into master will increase coverage by 0.39%.
The diff coverage is 88.93%.

@@            Coverage Diff             @@
##           master    #2464      +/-   ##
==========================================
+ Coverage   74.68%   75.07%   +0.39%     
==========================================
  Files         320      323       +3     
  Lines       56444    56838     +394     
==========================================
+ Hits        42157    42673     +516     
+ Misses      14287    14165     -122

janezd · 2017-07-21T08:21:05Z

Orange/widgets/utils/messages.py

+        if messages:
+            self.message_bar.setMessages(
+                (m, msg(m)) for i, m in enumerate(messages)
+            )


Why enumerate and i?

Leftovers from intermediate implementation

janezd · 2017-07-21T08:27:20Z

Orange/widgets/utils/messagewidget.py

+    device.close()
+    data = bytes(device.data())
+    payload = base64.b64encode(data).decode("ascii")
+    return "data:image/png;base64," + payload


This could be also useful elsewhere. Do we have a suitable place for such functions? (If not, ignore.)

I don't know. Orange.widgets.utils??

janezd · 2017-07-21T08:29:09Z

Orange/widgets/utils/messagewidget.py

+
+def standard_pixmap(severity):
+    # type: (Severity) -> QStyle.StandardPixmap
+    maping = {


janezd · 2017-07-21T09:05:49Z

I'm eager to merge it, except for one (maybe two) small things.

Before, the "summary" in the message bar showed the text up to the first line break, and the entire message was shown in the tooltip.

Now, it shows the entire message.

I'd prefer if the text in the bar was limited to a single line.

You may not need to fix this: as I understand, the message can now include a short text, a more detailed text ... This is certainly better than splitting by \n --- except that the Msg class doesn't yet accept this attributes. Instead of reimplementing the old functionality (which is used only by a few widgets), you could add the necessary arguments to UnboundMsg.__new__ (and _BoundMsg.__call__ to allow string formatting).

The other thing - also visible in these screenshots - is the width of the tooltip, which used to resize to content.

ales-erjavec · 2017-07-21T11:28:03Z

I restored the previous line splitting behavior, and tooltip wrapping.
_BoundMsg.__call__ also has a new exc_info parameter to include exception traceback in the message.

Move the message area to the bottom into a status bar.

Move the status bar out of the widget's layout and in to its content margins.

See QRect.{bottom,right}

Restore old behaviour.

Better styling w.r.t enabled/active state.

Make the overlay positioning independent of global screen coordinates when the overlay and the target widget are contained within the same window. When the window is resized (on OSX 10.11) PyQt4 only reports resize events, even when the actual window position (top left corner of the window) changes (e.g. by dragging the top window border).

ales-erjavec force-pushed the widget-status-bar branch from 98c6523 to a7e9a78 Compare July 11, 2017 12:12

ales-erjavec force-pushed the widget-status-bar branch 2 times, most recently from 1a70dbe to 7861908 Compare July 18, 2017 08:40

janezd reviewed Jul 21, 2017

View reviewed changes

ales-erjavec force-pushed the widget-status-bar branch 2 times, most recently from d07775c to 60404e7 Compare July 21, 2017 11:25

janezd approved these changes Jul 21, 2017

View reviewed changes

ales-erjavec force-pushed the widget-status-bar branch 2 times, most recently from 14d0b73 to 27eec1c Compare July 24, 2017 10:48

ales-erjavec force-pushed the widget-status-bar branch from 27eec1c to eec6fc9 Compare August 3, 2017 08:31

ales-erjavec mentioned this pull request Aug 3, 2017

[ENH] Widget status bar buttons #2514

Merged

3 tasks

ales-erjavec force-pushed the widget-status-bar branch 3 times, most recently from 535dd57 to d845e2c Compare August 11, 2017 09:37

ales-erjavec changed the title ~~[RFC][ENH] Widget status bar~~ [ENH] Widget status bar Aug 11, 2017

ales-erjavec force-pushed the widget-status-bar branch 3 times, most recently from f699cec to d2670fd Compare August 14, 2017 17:25

ales-erjavec added 5 commits August 16, 2017 09:36

MessagesWidget: Add a new utility widget for displaying state/messages

0608881

OWWidget: Replace 'message_bar' implementation

134873b

Move the message area to the bottom into a status bar.

OWWidget: Progress bar widget in the status bar

7dd61eb

OWWidget: Change status bar layout strategy

95a6871

Move the status bar out of the widget's layout and in to its content margins.

OverlayWidget: Fix layouting for bottom and right alignment

db37d5b

See QRect.{bottom,right}

ales-erjavec force-pushed the widget-status-bar branch 3 times, most recently from 3df1f8d to 8b87b4f Compare August 16, 2017 12:29

utils/messages: Capture exc_info in messages

8dacd50

ales-erjavec added 7 commits August 17, 2017 16:28

utils/messages: Split message text on first new line (if any)

fc99b8c

Restore old behaviour.

MessagesWidget: Fix message html rendering

8109584

messagewidget: Implement and use IconWidget

8c678a5

Better styling w.r.t enabled/active state.

overlay: Ensure overlay is properly positioned on show event

ccc86eb

overlay: Move and improve tests

4115647

overlay: Handle invalid sizeHint

2b31e82

ales-erjavec force-pushed the widget-status-bar branch from 8b87b4f to 2b31e82 Compare August 17, 2017 14:42

astaric assigned janezd Aug 18, 2017

janezd merged commit 7253546 into biolab:master Aug 18, 2017

ajdapretnar mentioned this pull request Sep 8, 2017

Hardly readable warning or error messages #2081

Closed

ales-erjavec deleted the widget-status-bar branch November 14, 2017 09:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ENH] Widget status bar#2464

[ENH] Widget status bar#2464
janezd merged 13 commits intobiolab:masterfrom
ales-erjavec:widget-status-bar

ales-erjavec commented Jul 11, 2017

Uh oh!

codecov-io commented Jul 11, 2017 •

edited

Loading

Uh oh!

janezd Jul 21, 2017

Uh oh!

ales-erjavec Jul 21, 2017

Uh oh!

janezd Jul 21, 2017

Uh oh!

ales-erjavec Jul 21, 2017

Uh oh!

janezd Jul 21, 2017

Uh oh!

ales-erjavec Jul 21, 2017

Uh oh!

janezd commented Jul 21, 2017

Uh oh!

ales-erjavec commented Jul 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ales-erjavec commented Jul 11, 2017

Issue

Description of changes

Includes

Uh oh!

codecov-io commented Jul 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

janezd Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

ales-erjavec Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

janezd Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

ales-erjavec Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

janezd Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

ales-erjavec Jul 21, 2017

Choose a reason for hiding this comment

Uh oh!

janezd commented Jul 21, 2017

Uh oh!

ales-erjavec commented Jul 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Jul 11, 2017 •

edited

Loading